Code Reviews¶
TL;DR — PRs to
devneed 1–2 approvals (varies by team). PRs tomasterneed at least 1. Ownership is by team — no formalCODEOWNERSfiles; reviewers are chosen based on the Bitbucket project the repo belongs to.
Overview¶
Code reviews are mandatory on every PR. Rules vary by target branch and by team culture.
Approval rules¶
| Target branch | Approvals required |
|---|---|
dev |
1–2 approvals (varies by team) |
master |
minimum 1 mandatory |
Ownership model¶
- Each repo belongs to a Bitbucket project owned by a team — see teams.md.
- There are no formal
CODEOWNERSfiles per repo. Reviewer selection is informal, based on team ownership. - If you need to know who owns a repo, look up its Bitbucket project in teams.md.
Automated checks¶
Code reviews are complemented by automated checks:
- Bitbucket Pipelines (CI) — lint, build, tests, Docker build. See bitbucket-ci.md.
- Code Insights coverage — total/patch coverage thresholds enforced on PRs. See code-insights.md for the defaults and per-repo overrides.
- Coverage merge check — Forge app blocking merge if coverage FAILED. See code-insights.md.
Reviewers focus on logic, design, and correctness — automated checks handle style, coverage, and build validity.
Current state¶
- PR review times: vary depending on team capacity.
- No standardized review checklist — reviews rely on reviewer judgment.
See also¶
- Teams & Projects — Ownership by Bitbucket project.
- Bitbucket Pipelines (CI) — Automated pre-merge checks.
- Code Insights & Coverage — Coverage gating.